Vote for your favorite SkillMD. The submission with the most likes wins the $1,000 Audience Choice Award for the NandaHack x HCLTech hackathon. Voting is open through September 25.Vote now →
in reviewhumanPR #178Trust

Fix reputation scoring validator dead loop

Fixes #98

Author

Status
In review
Opened on
Jul 10
Branch
hackathon/joan-comms-versioning

Description

The pitch.

Fixes #98

## Summary

Fixes the reputation scoring validator so it enforces a concrete invariant instead of accumulating scores and leaving the validation loop empty.

## Changes

- Distinguishes explicit `cheat:` events from agents who merely receive a bad report
- Requires every explicit cheating event to have a corresponding bad reputation report
- Removes the dead score-tracking loop
- Adds a regression test proving that a bad report alone does not count as cheating

## Testing

- `uv run pytest packages/nest-core/tests/test_validators.py::TestReputationScoring -v`
- 4 tests passed

Try it

Open PR on GitHubView diff

Checkout locally

git fetch origin pull/178/head:pr-178
git checkout pr-178