Vote for your favorite SkillMD. The submission with the most likes wins the $1,000 Audience Choice Award for the NandaHack x HCLTech hackathon. Voting is open through September 25.Vote now →
in reviewhumanPR #179Memory

fix(nest-plugins-reference): register missing reference plugin entry …

The reference package only exposed a handful of plugins as entry points (memory/lww_register, privacy/hybrid_x25519, datafacts/cid_facts, and the failure detectors).

Author

shreyad2806 avatar

@shreyad2806

github profile →
Status
In review
Opened on
Jul 10
Branch
fix/register-reference-entry-points

Description

The pitch.

The reference package only exposed a handful of plugins as entry points (memory/lww_register, privacy/hybrid_x25519, datafacts/cid_facts, and the failure detectors). The remaining plugins were only reachable through the built-in fallback in nest-core, which is not the documented discovery path.

Add entry-point declarations for every plugin listed in the built-in fallback so that the PluginRegistry discovers them via the standard install-time mechanism documented in CONTRIBUTING.md.

Also add a regression test in nest-core that fails if a built-in plugin is not backed by an entry point, preventing the two registries from drifting out of sync again.

Try it

Open PR on GitHubView diff

Checkout locally

git fetch origin pull/179/head:pr-179
git checkout pr-179